-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Okta: add User_Role_Assignments and Group_Role_Assignments #14556
Conversation
b291650
to
3a38742
Compare
/test connector=connectors/source-okta
Build FailedTest summary info:
|
c9fb3f1
to
8a6d5a9
Compare
@YiyangLi can you solve the conflicts? |
- it's all about okta source connector - these 2 API streams don't support the sync mode incremental, the api doesn's mention cursor or pagination for these 2 APIs - add $id to shared schema, rename shared schema
Hi, @harshithmullapudi the conflicts have been addressed, can you help run the test again? |
/test connector=connectors/source-okta
Build FailedTest summary info:
|
@marcosmarxm I saw the test fails at I included the steps to create a group role assignment in an okta org, can you create one and run the test again? FYI, creating a group role assignment on a group without members wouldn't affect your org setup. |
/test connector=connectors/source-okta
Build PassedTest summary info:
|
Thanks @YiyangLi a lot for the directions I was able to get that thing done |
/publish connector=connectors/source-okta
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-okta
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Branched out from https://github.com/YiyangLi/airbyte/tree/YL_add-group_members-to-okta_source, please review the PR first 🎉 Source Okta: add GroupMembers stream #14380It's ready to review.How
Describe the solution
Recommended reading order
source.python
source_okta/schemas/shared/shared-role.json
🚨 User Impact 🚨
No really, new API streams
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance